From 707f4583d330aa91375664eb02d6f4424e0c72e0 Mon Sep 17 00:00:00 2001 From: groug Date: Tue, 14 Feb 2023 17:33:39 +0100 Subject: [PATCH] remove trigger_all, since it was used on a specific project, it doesn't have its place here (and it's costly) --- state_machine.gd | 6 ------ 1 file changed, 6 deletions(-) diff --git a/state_machine.gd b/state_machine.gd index 63f5440..6d82de1 100644 --- a/state_machine.gd +++ b/state_machine.gd @@ -94,8 +94,6 @@ func _change_state(name): if index != -1: var old_state = get_current_state() var exit_name = _get_on_state_exit_method_name(old_state) - # TODO: do not always call triggers (costly?) - trigger_all(exit_name) if parent_node.has_method(exit_name): Callable(parent_node, exit_name).call() @@ -106,7 +104,6 @@ func _change_state(name): print(get_parent().name, "'s new state: ", name) var enter_name = _get_on_state_enter_method_name(name) - trigger_all(enter_name) if parent_node.has_method(enter_name): Callable(parent_node, enter_name).call() @@ -178,6 +175,3 @@ func add_transition(source, dest, conditions, trigger_name=''): func trigger(trigger_name): if not _current_triggers.has(trigger_name): _current_triggers.append(trigger_name) - -func trigger_all(trigger_name): - get_tree().call_group("state_machine", "trigger", String(get_parent().name) + "_" + trigger_name)