Use one-liners in specs where possible

This commit is contained in:
Thibault Jouan
2014-04-01 18:32:22 +00:00
parent 4cef7aeab9
commit 0c7bf69ba2
22 changed files with 35 additions and 103 deletions

View File

@@ -2,12 +2,8 @@ require 'spec_helper'
describe 'home/index' do
before do
assign :playlists, [
mock_model(Playlist, name: 'Electro')
]
assign :tracks, [
mock_model(Track, name: 'Mega song')
]
assign :playlists, [mock_model(Playlist, name: 'Electro')]
assign :tracks, [mock_model(Track, name: 'Mega song')]
end
it 'displays a list of playlists' do

View File

@@ -1,13 +1,9 @@
require 'spec_helper'
describe 'playlists/edit' do
let(:playlist) do
mock_model(Playlist).as_new_record.as_null_object
end
let(:playlist) { mock_model(Playlist).as_new_record.as_null_object }
before do
assign :playlist, playlist
end
before { assign :playlist, playlist }
it 'renders a form to edit a playlist' do
render

View File

@@ -1,11 +1,7 @@
require 'spec_helper'
describe 'playlists/index' do
before do
assign :playlists, [
mock_model(Playlist, name: 'Electro')
]
end
before { assign :playlists, [mock_model(Playlist, name: 'Electro')] }
it 'displays a list of playlists' do
render

View File

@@ -1,20 +1,15 @@
require 'spec_helper'
describe 'playlists/new' do
let(:playlist) do
mock_model(Playlist).as_new_record.as_null_object
end
let(:playlist) { mock_model(Playlist).as_new_record.as_null_object }
before do
assign :playlist, playlist
end
before { assign :playlist, playlist }
it 'renders a form to create a playlist' do
render
expect(rendered)
.to have_selector "form[method=post][action='#{playlists_path}']"
expect(rendered)
.to have_selector 'input[type=submit]'
expect(rendered).to have_selector 'input[type=submit]'
end
it 'renders a text field with a label for the playlists name' do
@@ -22,7 +17,6 @@ describe 'playlists/new' do
render
expect(rendered)
.to have_selector "input[type=text][name='playlist[name]'][value=Electro]"
expect(rendered)
.to have_selector 'label[for=playlist_name]', text: 'Name'
expect(rendered).to have_selector 'label[for=playlist_name]', text: 'Name'
end
end

View File

@@ -1,13 +1,9 @@
require 'spec_helper'
describe 'tracks/new' do
let(:track) do
mock_model(Track).as_new_record.as_null_object
end
let(:track) { mock_model(Track).as_new_record.as_null_object }
before do
assign :track, track
end
before { assign :track, track }
it 'renders a form to create a track' do
render
@@ -21,8 +17,7 @@ describe 'tracks/new' do
render
expect(rendered)
.to have_selector "input[type=text][name='track[name]'][value='Mega song']"
expect(rendered)
.to have_selector('label[for=track_name]', text: 'Name')
expect(rendered).to have_selector('label[for=track_name]', text: 'Name')
end
it 'renders a file field with a label for the tracks file' do

View File

@@ -3,9 +3,7 @@ require 'spec_helper'
describe 'tracks/show' do
let(:track) { FactoryGirl.create(:track) }
before do
assign :track, track
end
before { assign :track, track }
it 'displays the name of the track' do
render

View File

@@ -1,13 +1,9 @@
require 'spec_helper'
describe 'users/new' do
let(:user) do
mock_model(User).as_new_record.as_null_object
end
let(:user) { mock_model(User).as_new_record.as_null_object }
before do
assign :user, user
end
before { assign :user, user }
it 'renders a form to sign up' do
render
@@ -19,8 +15,7 @@ describe 'users/new' do
it 'renders a text field with a label for the mail address' do
render
expect(rendered).to have_selector "input[type=text][name='user[email]']"
expect(rendered)
.to have_selector 'label[for=user_email]', text: 'Email'
expect(rendered).to have_selector 'label[for=user_email]', text: 'Email'
end
it 'renders a password field with a label for the password' do