Improve coding standards

This commit is contained in:
Thibault Jouan 2013-12-20 06:46:28 +00:00
parent 0b68a8165d
commit 9251c6af8e
4 changed files with 21 additions and 15 deletions

View File

@ -1,10 +1,10 @@
module Producer module Producer
module Core module Core
class CLI class CLI
attr_reader :arguments
USAGE = "Usage: #{File.basename $0} recipe_file" USAGE = "Usage: #{File.basename $0} recipe_file"
attr_reader :arguments
def initialize(arguments, stdout = $stdout) def initialize(arguments, stdout = $stdout)
@stdout = stdout @stdout = stdout
@arguments = arguments @arguments = arguments

View File

@ -1,11 +1,13 @@
module Producer module Producer
module Core module Core
class Recipe class Recipe
attr_accessor :tasks class << self
def evaluate_from_file(filepath, env)
def self.evaluate_from_file(filepath, env)
DSL.evaluate(File.read(filepath), env) DSL.evaluate(File.read(filepath), env)
end end
end
attr_accessor :tasks
def initialize(tasks = []) def initialize(tasks = [])
@tasks = tasks @tasks = tasks

View File

@ -2,12 +2,14 @@ module Producer
module Core module Core
class Recipe class Recipe
class DSL class DSL
attr_reader :tasks class << self
def evaluate(code, env)
def self.evaluate(code, env)
dsl = new(code).evaluate(env) dsl = new(code).evaluate(env)
Recipe.new(dsl.tasks) Recipe.new(dsl.tasks)
end end
end
attr_reader :tasks
def initialize(code = nil, &block) def initialize(code = nil, &block)
@code = code @code = code

View File

@ -1,11 +1,13 @@
module Producer module Producer
module Core module Core
class Task class Task
attr_reader :name, :actions, :condition class << self
def evaluate(name, env, &block)
def self.evaluate(name, env, &block)
DSL.evaluate(name, env, &block) DSL.evaluate(name, env, &block)
end end
end
attr_reader :name, :actions, :condition
def initialize(name, actions = [], condition = true) def initialize(name, actions = [], condition = true)
@name = name @name = name