tj/producer-core
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix backtrace filtering for producer own code

Browse Source 
Using /producer-\w+ as pattern is incorrect, we have no guarantee that
the canonical repository or gem name will be included in the install
path. Just use /producer pattern to match lib files or executables.
This commit is contained in:
Thibault Jouan 2015-04-04 20:15:22 +00:00
parent c9971d7ca0
commit dbe7fea204
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
features/cli/debug.feature
View File

@ -8,6 +8,6 @@ Feature: CLI debug option
Scenario: does not exclude anything from backtrace Scenario: does not exclude anything from backtrace
Given a recipe using a remote Given a recipe using a remote
When I execute the recipe on unknown remote target with option -d When I execute the recipe on unknown remote target with option -d
Then the output must contain "producer-core" Then the output must contain "producer"
And the output must contain "net-ssh" And the output must contain "net-ssh"
And the output must contain ruby lib directory And the output must contain ruby lib directory

2
lib/producer/core/error_formatter.rb
View File

@ -2,7 +2,7 @@ module Producer
module Core module Core
class ErrorFormatter class ErrorFormatter
FILTERS = [ FILTERS = [
/\/producer-\w+/, /\/producer/,
Regexp.new(RbConfig::CONFIG['rubylibdir']), Regexp.new(RbConfig::CONFIG['rubylibdir']),
/\/net-ssh/, /\/net-ssh/,
/\/net-sftp/ /\/net-sftp/

6
spec/producer/core/error_formatter_spec.rb
View File

@ -24,7 +24,7 @@ module Producer
describe '#format' do describe '#format' do
let(:rubylibdir) { RbConfig::CONFIG['rubylibdir'] } let(:rubylibdir) { RbConfig::CONFIG['rubylibdir'] }
let(:bt) { %W[backtrace /producer-core /net-ssh #{rubylibdir}] } let(:bt) { %W[backtrace /producer /net-ssh #{rubylibdir}] }
let(:exception) { RuntimeError.new('some exception').tap { |o| o.set_backtrace bt } } let(:exception) { RuntimeError.new('some exception').tap { |o| o.set_backtrace bt } }
def exception_with_cause def exception_with_cause
@ -43,7 +43,7 @@ module Producer
end end
it 'excludes producer code from the backtrace' do it 'excludes producer code from the backtrace' do
expect(formatter.format exception).not_to include 'producer-core' expect(formatter.format exception).not_to include 'producer'
end end
it 'excludes net-ssh from the backtrace' do it 'excludes net-ssh from the backtrace' do
@ -65,7 +65,7 @@ module Producer
let(:debug) { true } let(:debug) { true }
it 'does not filter the backtrace' do it 'does not filter the backtrace' do
expect(formatter.format exception).to include 'producer-core' expect(formatter.format exception).to include 'producer'
end end
context 'when exception has a cause' do context 'when exception has a cause' do