Improve small details in specs:

* Fix coding standards;
* Simplify some expectations (eq instead of be matcher);
* Expect identity on block instead of calling;
* Change some before call as oneliners;
* Avoid shadowing variable names;
* Improve wording where needed.
This commit is contained in:
Thibault Jouan
2013-12-19 21:17:03 +00:00
parent f5224c7569
commit ef0307fbb5
15 changed files with 68 additions and 78 deletions

View File

@@ -8,7 +8,7 @@ module Producer::Core
subject(:condition) { Condition.new(tests) }
describe '.evaluate' do
let(:env) { double('env') }
let(:env) { double 'env' }
let(:block) { proc { :some_condition_code } }
it 'delegates to DSL.evaluate' do
@@ -20,7 +20,7 @@ module Producer::Core
end
it 'returns the evaluated condition' do
condition = double('condition')
condition = double 'condition'
allow(Condition::DSL).to receive(:evaluate) { condition }
expect(Condition.evaluate(env, &block)).to be condition
end