Improve small details in specs:

* Fix coding standards;
* Simplify some expectations (eq instead of be matcher);
* Expect identity on block instead of calling;
* Change some before call as oneliners;
* Avoid shadowing variable names;
* Improve wording where needed.
This commit is contained in:
Thibault Jouan
2013-12-19 21:17:03 +00:00
parent f5224c7569
commit ef0307fbb5
15 changed files with 68 additions and 78 deletions

View File

@@ -7,7 +7,7 @@ module Producer::Core
subject(:recipe) { Recipe.new }
describe '.evaluate_from_file' do
let(:env) { double('env') }
let(:env) { double 'env' }
let(:filepath) { fixture_path_for 'recipes/empty.rb' }
it 'delegates to DSL.evaluate with the recipe file content' do
@@ -17,7 +17,7 @@ module Producer::Core
end
it 'returns the evaluated recipe' do
recipe = double('recipe')
recipe = double 'recipe'
allow(Recipe::DSL).to receive(:evaluate) { recipe }
expect(Recipe.evaluate_from_file(filepath, env)).to be recipe
end