tj/producer-core
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
470 Commits 1 Branch 0 Tags
Commit Graph

270 Commits

Author SHA1 Message Date
Thibault Jouan
d4d5222261 Refactor task DSL usages: 
Remove most of task evaluation code from Task class, rely on
Task::DSL.evaluate to get an evaluated task.

* Task: remove #evaluate, change constructor prototype to accept actions
  instead of a block, implement .evaluate(name, env &block);
* Implement Task::DSL.evaluate method;
* Recipe::DSL: remove tasks evaluation from#evaluate, modify #task to
  use Task.evaluate to return the new task to be rigstered.
 2013-08-15 22:28:16 +00:00
Thibault Jouan
000c21e094 Remove uneeded call in Recipe::DSL#env spec 2013-08-15 22:28:11 +00:00
Thibault Jouan
a675c9c910 Implement `echo' task action 2013-08-14 23:43:36 +00:00
Thibault Jouan
f0e144cebd Refactor and simplify recipe DSL evaluation usages: 
Remove most of recipe evaluation code in Recipe class, and rely on
Recipe::DSL to get evaluated recipes.

* Remove Recipe#evaluate call from CLI, rely on
  Recipe.evaluate_from_file to get the evaluated recipe;
* Implement Recipe.evaluate_from_file(filepath, env);
* Implement Recipe::DSL.evaluate(code, env);
* Remove code and filepath accessor on Recipe;
* Remove Recipe.from_file and Recipe#evaluate methods;
* Move task evaluations in Recipe::DSL#evaluate;
* Modify Recipe constructor so that it accepts tasks as argument.
 2013-08-14 19:48:43 +00:00
Thibault Jouan
7c5d5b0417 Improve Recipe::DSL#initialize spec 
Fix current examples by testing assignations, and add missing example
about @tasks assignation.
 2013-08-13 22:47:23 +00:00
Thibault Jouan
53db841b2d Remove Env#current_recipe attribute 2013-08-13 01:36:33 +00:00
Thibault Jouan
a5d9ca26f4 Remove error handling for evaluation errors 2013-08-13 00:42:14 +00:00
Thibault Jouan
0904fa1fc9 Implement Worker class: 
* Move recipe processing code in the worker;
* Refactor CLI and use the the worker;
* Implement Recipe#tasks and remove tasks application during evaluation,
  tasks are now applied by the worker after all evaluations are done.
 2013-08-10 14:47:02 +00:00
Thibault Jouan
ec44d01c36 Fix coding standards in shell command action spec 2013-08-10 14:46:31 +00:00
Thibault Jouan
825bdec74d Improve `sh' task action error handling: 
Handle exit status code in Remote#execute.
 2013-08-07 23:39:49 +00:00
Thibault Jouan
f10914c7d7 Implement basic `sh' task action feature: 
* Executes a command on the remote host;
* Forwards remote standard output.
 2013-08-07 16:16:40 +00:00
Thibault Jouan
8123cf5052 Add Task#initialize spec 2013-08-07 01:22:46 +00:00
Thibault Jouan
dff95b2c4b Fix coding standards in Env spec 2013-08-07 01:22:12 +00:00
Thibault Jouan
b8fd24973a Improve Task::DSL spec: 
* Improve #initialize spec wording and expectation;
* Add #actions spec.
 2013-08-07 01:16:00 +00:00
Thibault Jouan
3ef533b67a Move Recipe::DSL#tasks example in spec file 2013-08-07 01:07:13 +00:00
Thibault Jouan
ef96a2db82 Improve naming in Remote#execute spec 2013-08-06 20:45:42 +00:00
Thibault Jouan
22ae12185d Improve Recipe spec: 
* Fix coding standards;
* Add spec for default assigned filepath;
* Add spec for #filepath accessor;
* Test object identity in #code spec.
 2013-08-06 20:39:17 +00:00
Thibault Jouan
29563f6cc6 Add missing spec for Recipe::DSL#task 2013-08-06 20:31:14 +00:00
Thibault Jouan
d552c698de Improve Env#output spec: 
Test the receiving output object state instead of expecting that it
will receive a specific message.
 2013-08-06 20:12:02 +00:00
Thibault Jouan
31b9e68026 Improve Env#initialize spec: 
Test that #current_recipe returns exactly the assigned recipe
(argument given to the constructor).
 2013-08-06 20:07:39 +00:00
Thibault Jouan
863155b61d Improve wording in Env#initialize spec 2013-08-06 20:06:05 +00:00
Thibault Jouan
883d4f2e7e Fix coding standards in remote spec 2013-08-06 20:02:27 +00:00
Thibault Jouan
9285a951c7 Add missing spec for CLI#initialize 2013-08-06 20:02:23 +00:00
Thibault Jouan
779eb72c32 Improve wording in CLI#arguments spec 2013-08-06 19:41:48 +00:00
Thibault Jouan
bd1bdba9cf Fix CLI#evaluate_recipe_file spec: 
The spec wasn't covering the case when recipe evaluation raises an
unexpected error.
 2013-08-06 19:38:33 +00:00
Thibault Jouan
eaccf55581 Improve CLI spec: 
Test #arguments accessor instead of testing the constructor.
 2013-08-06 19:17:22 +00:00
Thibault Jouan
889ddf84e4 Fix Action#env spec: 
Test that we get the exact assigned object, instead of just testing
equality.
 2013-08-06 19:11:29 +00:00
Thibault Jouan
580ad66bab Use new rspec metadata arguments as symbol 2013-08-06 18:34:53 +00:00
Thibault Jouan
cff122432b Refactor Net::SSH spec helpers definition and usages 2013-08-06 17:29:45 +00:00
Thibault Jouan
5d9a5f1f57 Simplify spec helper: 
Move specific exception `SomeErrorInRecipe' in the only spec where it
is used.
 2013-08-06 17:13:41 +00:00
Thibault Jouan
9875a4ae7b Make remote available to env 2013-08-05 20:05:58 +00:00
Thibault Jouan
ace5bfb3fa Add basic Remote#execute implementation 2013-08-05 20:03:13 +00:00
Thibault Jouan
6e1ba269eb Implement Remote class 2013-08-05 19:58:17 +00:00
Thibault Jouan
ad63164d60 Fix coding standards in Env spec 2013-08-05 14:32:23 +00:00
Thibault Jouan
0cccbc8dde Add Env#output with $stdout as default 2013-08-04 21:29:13 +00:00
Thibault Jouan
e6c14f1903 Implement basic task actions API: 
* Add Action base class;
* Implement Task::DSL.define_action(keyword, klass);
* Add Task::DSL#actions accessor;
* Apply task DSL actions when Task instances are evaluated.
 2013-08-04 20:30:54 +00:00
Thibault Jouan
8e455fc4d5 Improve Env constructor 2013-08-04 15:45:08 +00:00
Thibault Jouan
a3bba6d4da Implement target recipe keyword feature 2013-08-03 23:42:47 +00:00
Thibault Jouan
a6e27edfd2 Add env recipe keyword feature 2013-08-03 23:42:41 +00:00
Thibault Jouan
d677c3aa97 Improve exceptions usage in specs: 
* Throw symbols instead of raising exceptions to test code evaluation,
  this will reduce "bad" usages of exceptions, symbols seems a little
  better for now;
* Add a specific exception to be used in specs for testing behaviour
  when an exception is raised from a recipe.
 2013-08-01 23:23:49 +00:00
Thibault Jouan
c3737e738e Refactor trap_exit spec helper usages 2013-08-01 22:51:41 +00:00
Thibault Jouan
c4fc9828db Improve error reporting during recipe evaluation 
* Report invalid action usages from tasks;
* Implement backtrace cleaning in CLI;
* Extract error class declarations in a new errors file;
* Replace raise with fail keyword in task DSL class.
 2013-08-01 20:31:39 +00:00
Thibault Jouan
836f9ffc29 Replaces Proc.new usages with proc keyword 2013-08-01 18:33:18 +00:00
Thibault Jouan
57ff1c73be Change "wording" in Recipe::DSL#evaluate spec 2013-08-01 17:18:15 +00:00
Thibault Jouan
ace6a4ad2b Implement Task::DSL#evaluate: 
So that the env is available from the task DSL.
 2013-08-01 00:01:20 +00:00
Thibault Jouan
a45a340b64 Improve some context descriptions in specs 2013-08-01 00:01:20 +00:00
Thibault Jouan
0aa043b61a Remove host argument: 
Currently the idea is to later implement a -h (or -t) option to the
command, and/or a `target' recipe keyword. Another option might be to
use the target/host key when the key/value registry will be implemented
and made available to the recipe and task DSLs.
 2013-08-01 00:01:20 +00:00
Thibault Jouan
2acb57254f Fix a few coding standards issues: 
* Remove extra empty lines before private keyword usages.

  specs:

  * Fix one long line;
  * use proc keyword instead of Proc.new.
 2013-08-01 00:01:20 +00:00
Thibault Jouan
3792f60a5c Improve source recipe keyword feature: 
* Improve error reporting from sourced recipe;
* Extract cucumber feature from recipe one.
 2013-08-01 00:01:19 +00:00
Thibault Jouan
b1c99dbeeb Extract task DSL code and spec 2013-08-01 00:01:19 +00:00