Implement `quit' action keyword

This commit is contained in:
Thibault Jouan 2015-04-15 03:39:09 +00:00
parent 0a83563cad
commit 49f85bee35
8 changed files with 80 additions and 5 deletions

View File

@ -0,0 +1,9 @@
Feature: `quit' action keyword
Scenario: requests quit when invoked
Given uhwm is running with this run control file:
"""
key(:f) { quit }
"""
When I press the alt+f keys
Then uhwm must terminate successfully

View File

@ -3,6 +3,7 @@ require 'logger'
require 'optparse' require 'optparse'
require 'uh' require 'uh'
require 'uh/wm/actions_handler'
require 'uh/wm/cli' require 'uh/wm/cli'
require 'uh/wm/dispatcher' require 'uh/wm/dispatcher'
require 'uh/wm/env' require 'uh/wm/env'

View File

@ -0,0 +1,17 @@
module Uh
module WM
class ActionsHandler
def initialize env, events
@env, @events = env, events
end
def evaluate code
instance_eval &code
end
def quit
@events.emit :quit
end
end
end
end

View File

@ -19,7 +19,9 @@ module Uh
def initialize output def initialize output
@output = output @output = output
@rc_path = RC_PATH @rc_path = RC_PATH
@keybinds = {} @keybinds = {
q: proc { quit }
}
end end
def verbose? def verbose?

View File

@ -14,12 +14,13 @@ module Uh
extend Forwardable extend Forwardable
def_delegator :@env, :layout def_delegator :@env, :layout
attr_reader :env, :events, :manager attr_reader :env, :events, :manager, :actions
def initialize env, manager: nil, stopped: false def initialize env, manager: nil, stopped: false
@env = env @env = env
@events = Dispatcher.new @events = Dispatcher.new
@manager = manager || Manager.new(@events) @manager = manager || Manager.new(@events)
@actions = ActionsHandler.new(@env, @events)
@stopped = stopped @stopped = stopped
end end
@ -36,6 +37,7 @@ module Uh
end end
def register_event_hooks def register_event_hooks
register_runner_hooks
register_manager_hooks register_manager_hooks
register_layout_event_hooks register_layout_event_hooks
register_key_bindings_hooks register_key_bindings_hooks
@ -43,7 +45,6 @@ module Uh
def connect_manager def connect_manager
@manager.connect @manager.connect
@manager.grab_key :q
@env.keybinds.each do |keysym, _| @env.keybinds.each do |keysym, _|
@manager.grab_key *keysym @manager.grab_key *keysym
end end
@ -56,6 +57,10 @@ module Uh
private private
def register_runner_hooks
@events.on(:quit) { stop! }
end
def register_manager_hooks def register_manager_hooks
@events.on(:connecting) do |display| @events.on(:connecting) do |display|
@env.log_debug "Connecting to X server on `#{display}'" @env.log_debug "Connecting to X server on `#{display}'"
@ -72,9 +77,10 @@ module Uh
end end
def register_key_bindings_hooks def register_key_bindings_hooks
@events.on(:key, :q) { stop! }
@env.keybinds.each do |keysym, code| @env.keybinds.each do |keysym, code|
@events.on :key, *keysym, &code @events.on :key, *keysym do
@actions.evaluate code
end
end end
end end
end end

View File

@ -0,0 +1,23 @@
module Uh
module WM
RSpec.describe ActionsHandler do
let(:env) { Env.new(StringIO.new) }
let(:events) { Dispatcher.new }
subject(:actions) { described_class.new env, events }
describe '#evaluate' do
it 'evaluates given code' do
expect { actions.evaluate proc { throw :action_code } }
.to throw_symbol :action_code
end
end
describe '#quit' do
it 'emits the quit event' do
expect(events).to receive(:emit).with :quit
actions.quit
end
end
end
end
end

View File

@ -21,6 +21,10 @@ module Uh
expect(env.layout_class).not_to be expect(env.layout_class).not_to be
end end
it 'has defaults key bindings set' do
expect(env.keybinds.keys).to eq %i[q]
end
describe '#verbose?' do describe '#verbose?' do
context 'when verbose mode is disabled' do context 'when verbose mode is disabled' do
before { env.verbose = false } before { env.verbose = false }

View File

@ -63,6 +63,12 @@ module Uh
end end
describe '#register_event_hooks' do describe '#register_event_hooks' do
it 'registers quit event hook' do
runner.register_event_hooks
expect(runner).to receive(:stop!)
runner.events.emit :quit
end
it 'registers manager event hooks for logging' do it 'registers manager event hooks for logging' do
runner.register_event_hooks runner.register_event_hooks
expect(env).to receive(:log) expect(env).to receive(:log)
@ -86,6 +92,13 @@ module Uh
runner.register_event_hooks runner.register_event_hooks
expect(runner.events[:key, :f, :shift]).not_to be_empty expect(runner.events[:key, :f, :shift]).not_to be_empty
end end
it 'registers key bindings code evaluation with the actions handler' do
env.keybinds[:f] = code = proc { }
runner.register_event_hooks
expect(runner.actions).to receive(:evaluate).with code
runner.events.emit :key, :f
end
end end
describe '#connect_manager' do describe '#connect_manager' do