groug/godot_simple_state_machine
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove trigger_all, since it was used on a specific project, it doesn't have its place here (and it's costly)

Browse Source
This commit is contained in:
groug 2023-02-14 17:33:39 +01:00
parent fe2f89e57e
commit 707f4583d3
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
state_machine.gd
View File

@ -94,8 +94,6 @@ func _change_state(name):
if index != -1: if index != -1:
var old_state = get_current_state() var old_state = get_current_state()
var exit_name = _get_on_state_exit_method_name(old_state) var exit_name = _get_on_state_exit_method_name(old_state)
# TODO: do not always call triggers (costly?)
trigger_all(exit_name)
if parent_node.has_method(exit_name): if parent_node.has_method(exit_name):
Callable(parent_node, exit_name).call() Callable(parent_node, exit_name).call()
@ -106,7 +104,6 @@ func _change_state(name):
print(get_parent().name, "'s new state: ", name) print(get_parent().name, "'s new state: ", name)
var enter_name = _get_on_state_enter_method_name(name) var enter_name = _get_on_state_enter_method_name(name)
trigger_all(enter_name)
if parent_node.has_method(enter_name): if parent_node.has_method(enter_name):
Callable(parent_node, enter_name).call() Callable(parent_node, enter_name).call()
@ -178,6 +175,3 @@ func add_transition(source, dest, conditions, trigger_name=''):
func trigger(trigger_name): func trigger(trigger_name):
if not _current_triggers.has(trigger_name): if not _current_triggers.has(trigger_name):
_current_triggers.append(trigger_name) _current_triggers.append(trigger_name)
func trigger_all(trigger_name):
get_tree().call_group("state_machine", "trigger", String(get_parent().name) + "_" + trigger_name)